Skip to content

TypeObjectRegistry refactor [21135] - #792

Merged
EduPonz merged 2 commits into
masterfrom
feature/type-registry-refactor
Jun 14, 2024
Merged

TypeObjectRegistry refactor [21135]#792
EduPonz merged 2 commits into
masterfrom
feature/type-registry-refactor

Conversation

@richiware

@richiware richiware commented Jun 3, 2024 •
edited by EduPonz
Loading

Copy link
Copy Markdown
Member

Description

This PR only regenerate the IDL files.

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@richiware richiware changed the title TypeObjectRegistry refactor TypeObjectRegistry refactor [21135] Jun 3, 2024
@richiware
richiware requested a review from adriancampo June 5, 2024 10:41
@richiware

richiware commented Jun 5, 2024

Copy link
Copy Markdown
Member Author

@richiprosima please test_3 docs

@richiware

richiware commented Jun 10, 2024

Copy link
Copy Markdown
Member Author

@richiprosima please test_3 docs

adriancampo
adriancampo approved these changes Jun 10, 2024
View reviewed changes

@adriancampo adriancampo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
richiware force-pushed the feature/type-registry-refactor branch from 7a58126 to 562d62e Compare June 13, 2024 08:13
@richiware

richiware commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

@richiprosima please test_3 docs

richiware added 2 commits June 13, 2024 14:50
@richiware
Refs #21044. Regenerate idl files
31426e8 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
Refs #21044. Fix spelling
4ffc189 
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware
richiware force-pushed the feature/type-registry-refactor branch from 562d62e to 4ffc189 Compare June 13, 2024 12:50
@richiware

richiware commented Jun 13, 2024

Copy link
Copy Markdown
Member Author

@richiprosima please test_3 docs

@richiware richiware mentioned this pull request Jun 13, 2024
Merged
9 tasks
@EduPonz EduPonz added this to the v3.0.0 milestone Jun 14, 2024
@EduPonz
EduPonz merged commit 4e4d3ca into master Jun 14, 2024
@EduPonz
EduPonz deleted the feature/type-registry-refactor branch June 14, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@adriancampo adriancampo adriancampo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@richiware @adriancampo @EduPonz